doloro/av3-animation-as-crab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(BREAKING) Apply planned breaking changes as specified in the AAC V1 release:

Browse Source 
- As specified in the changelog for the official release of Animator As Code V1, breaking changes had been planned, and will be applied starting this version:
  - (BREAKING) AacFlSettingKeyframes constructor is now private.
    - For compatibility reasons, it was public for the duration of V1.1.x, and was already marked as obsolete in V1.1.x.
  - (BREAKING) The methods AacFlBase.InternalConfiguration and AacFlBase.InternalDoCreateLayer are now private.
    - For compatibility reasons, it was public for the duration of V1.1.x, and was already marked as obsolete in V1.1.x.
    - The class AacAccessorForExtensions replaced them.
This commit is contained in:
Haï~
2024-11-29 11:58:25 +01:00
parent e445ba8321
commit ff681e6d96
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/Aac.cs
+6 -6
View File
@@ -472,9 +472,9 @@ namespace AnimatorAsCode.V1
{ {
private readonly AacConfiguration _configuration; private readonly AacConfiguration _configuration;
/// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Maybe this can be improved /// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Has been replaced with AacAccessorForExtensions.AccessConfiguration
[Obsolete("This will be made private/internal in V1.2.0. Use AacAccessorForExtensions.AccessConfiguration(...) instead")] [Obsolete("This has been made private/internal in V1.2.0. Use AacAccessorForExtensions.AccessConfiguration(...) instead")]
public AacConfiguration InternalConfiguration() internal AacConfiguration InternalConfiguration()
{ {
return _configuration; return _configuration;
} }
@@ -583,9 +583,9 @@ namespace AnimatorAsCode.V1
/// Destructive workflow: Clears the topmost layer of an arbitrary AnimatorController, and returns it. /// Destructive workflow: Clears the topmost layer of an arbitrary AnimatorController, and returns it.
public AacFlLayer CreateFirstArbitraryControllerLayer(AnimatorController controller) => DoCreateLayer(controller, controller.layers[0].name); public AacFlLayer CreateFirstArbitraryControllerLayer(AnimatorController controller) => DoCreateLayer(controller, controller.layers[0].name);
/// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Maybe this can be improved /// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Has been replaced with AacAccessorForExtensions.CreateLayer
[Obsolete("This will be made private/internal in V1.2.0. Use AacAccessorForExtensions.CreateLayer(...) instead")] [Obsolete("This has been made private/internal in V1.2.0. Use AacAccessorForExtensions.CreateLayer(...) instead")]
public AacFlLayer InternalDoCreateLayer(AnimatorController animator, string layerName) internal AacFlLayer InternalDoCreateLayer(AnimatorController animator, string layerName)
{ {
return DoCreateLayer(animator, layerName); return DoCreateLayer(animator, layerName);
} }
Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/AacFlAnimations.cs
+2 -2
View File
@@ -649,8 +649,8 @@ namespace AnimatorAsCode.V1
private readonly List<Keyframe> _mutatedKeyframes; private readonly List<Keyframe> _mutatedKeyframes;
// Will be made private/internal in V1.2.0. // Will be made private/internal in V1.2.0.
[Obsolete("This will be made private/internal in V1.2.0")] [Obsolete("This has been made private/internal in V1.2.0")]
public AacFlSettingKeyframes(AacFlUnit unit, List<Keyframe> mutatedKeyframes) internal AacFlSettingKeyframes(AacFlUnit unit, List<Keyframe> mutatedKeyframes)
{ {
_unit = unit; _unit = unit;
_mutatedKeyframes = mutatedKeyframes; _mutatedKeyframes = mutatedKeyframes;