(BREAKING) Replace public readonly fields with properties:

- Fix inconsistency by replacing public readonly fields with getter-only properties.
- Add PublicAPI annotation where it was missing.
This commit is contained in:
Haï~
2024-08-18 04:23:51 +02:00
parent 98190a47d9
commit 0bddfdd7a3
3 changed files with 17 additions and 10 deletions
@@ -1,6 +1,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using JetBrains.Annotations;
using UnityEditor; using UnityEditor;
using UnityEditor.Animations; using UnityEditor.Animations;
using UnityEngine; using UnityEngine;
@@ -683,14 +684,14 @@ namespace AnimatorAsCode.V1
public class AacFlController public class AacFlController
{ {
/// Exposes the underlying Unity AnimatorController. /// Exposes the underlying Unity AnimatorController.
public readonly AnimatorController AnimatorController; [PublicAPI] public AnimatorController AnimatorController { get; }
private readonly AacConfiguration _configuration; private readonly AacConfiguration _configuration;
private readonly AacFlBase _base; private readonly AacFlBase _base;
public AacFlController(AacConfiguration configuration, AnimatorController animatorController, AacFlBase originalBase) public AacFlController(AacConfiguration configuration, AnimatorController animatorAnimatorController, AacFlBase originalBase)
{ {
AnimatorController = animatorController; AnimatorController = animatorAnimatorController;
_configuration = configuration; _configuration = configuration;
_base = originalBase; _base = originalBase;
} }
@@ -1,6 +1,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using JetBrains.Annotations;
using UnityEditor; using UnityEditor;
using UnityEngine; using UnityEngine;
using Object = UnityEngine.Object; using Object = UnityEngine.Object;
@@ -13,7 +14,7 @@ namespace AnimatorAsCode.V1
private readonly AacConfiguration _component; private readonly AacConfiguration _component;
/// Exposes the underlying Unity Clip asset. /// Exposes the underlying Unity Clip asset.
public AnimationClip Clip { get; } [PublicAPI] public AnimationClip Clip { get; }
public AacFlClip(AacConfiguration component, AnimationClip clip) public AacFlClip(AacConfiguration component, AnimationClip clip)
{ {
@@ -312,7 +313,7 @@ namespace AnimatorAsCode.V1
public class AacFlEditClip public class AacFlEditClip
{ {
private readonly AacConfiguration _component; private readonly AacConfiguration _component;
public AnimationClip Clip { get; } [PublicAPI] public AnimationClip Clip { get; }
public AacFlEditClip(AacConfiguration component, AnimationClip clip) public AacFlEditClip(AacConfiguration component, AnimationClip clip)
{ {
@@ -1,6 +1,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using JetBrains.Annotations;
using UnityEditor.Animations; using UnityEditor.Animations;
using UnityEngine; using UnityEngine;
@@ -111,7 +112,7 @@ namespace AnimatorAsCode.V1
public class AacFlStateMachine : AacAnimatorNode<AacFlStateMachine> public class AacFlStateMachine : AacAnimatorNode<AacFlStateMachine>
{ {
/// Exposes the underlying Unity AnimatorStateMachine object of this state machine. /// Exposes the underlying Unity AnimatorStateMachine object of this state machine.
public readonly AnimatorStateMachine Machine; [PublicAPI] public AnimatorStateMachine Machine { get; }
private readonly AnimationClip _emptyClip; private readonly AnimationClip _emptyClip;
private readonly AacBackingAnimator _backingAnimator; private readonly AacBackingAnimator _backingAnimator;
@@ -356,7 +357,9 @@ namespace AnimatorAsCode.V1
public class AacFlState : AacAnimatorNode<AacFlState> public class AacFlState : AacAnimatorNode<AacFlState>
{ {
public readonly AnimatorState State; /// Exposes the underlying Unity AnimatorState of this state.
[PublicAPI] public AnimatorState State { get; }
private readonly AnimatorStateMachine _machine; private readonly AnimatorStateMachine _machine;
public AacFlState(AnimatorState state, AacFlStateMachine parentMachine, IAacDefaultsProvider defaultsProvider, Transform animatorRoot) : base(parentMachine, defaultsProvider, animatorRoot) public AacFlState(AnimatorState state, AacFlStateMachine parentMachine, IAacDefaultsProvider defaultsProvider, Transform animatorRoot) : base(parentMachine, defaultsProvider, animatorRoot)
@@ -685,7 +688,9 @@ namespace AnimatorAsCode.V1
public class AacFlNewTransitionContinuation public class AacFlNewTransitionContinuation
{ {
public readonly AnimatorTransitionBase Transition; /// Exposes the underlying Unity AnimatorTransitionBase of this transition.
[PublicAPI] public AnimatorTransitionBase Transition { get; }
private readonly AnimatorStateMachine _machine; private readonly AnimatorStateMachine _machine;
private readonly AacTransitionEndpoint _sourceNullableIfAny; private readonly AacTransitionEndpoint _sourceNullableIfAny;
private readonly AacTransitionEndpoint _destinationNullableIfExits; private readonly AacTransitionEndpoint _destinationNullableIfExits;